-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update border colours on email/print buttons for greater contrast #3855
Conversation
405fb7b
to
780c6a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me, I think we will also need an Interaction Designer to help review as well.
The color choice of dark-grey
makes sense to me here from looking at the choice available in the Design System - https://design-system.service.gov.uk/styles/colour/
But we may also be able to us a tint to get some slightly different color variations as well:
If you need to use tints of this palette, use either 25% or 50%.
@MartinJJones Had a call with @nnagewad about this and he's happy from a design perspective. Also, looking at tints of the |
Thanks for checking, good to know about the contrast problem at 50% as well 👍 |
I just noticed one other small change required when reviewing the Visual changes in Percy The "With different href" variation of the "print link" component also needs the new border color - https://components-gem-pr-3855.herokuapp.com/component-guide/print_link/preview |
Oh yes, good spot, I'll have a look at that. |
780c6a9
to
dfa04d4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!, changes look good to me 👍
What
These changes update the colour of the border on the "Print link" and "Single page notification button" components.
Why
The borders on these components have been reported in DAC's audit to be too faint: #b1b4b6 against white is only a contrast of 2.1:1. Although this will not affect functionality of the button, it means that lots of people won’t see the border.
See Trello card 103 | Some button's borders are too faint
Visual Changes