Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update border colours on email/print buttons for greater contrast #3855

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

davidtrussler
Copy link
Contributor

What

These changes update the colour of the border on the "Print link" and "Single page notification button" components.

Why

The borders on these components have been reported in DAC's audit to be too faint: #b1b4b6 against white is only a contrast of 2.1:1. Although this will not affect functionality of the button, it means that lots of people won’t see the border.

See Trello card 103 | Some button's borders are too faint

Visual Changes

Print link Single page notification button
Before Screenshot 2024-02-06 at 10 09 14 Screenshot 2024-02-06 at 10 07 33
After Screenshot 2024-02-06 at 10 08 59 Screenshot 2024-02-06 at 10 07 54

@govuk-ci govuk-ci temporarily deployed to components-gem-pr-3855 February 6, 2024 10:14 Inactive
@davidtrussler davidtrussler force-pushed the 103_Button-borders-colour branch from 405fb7b to 780c6a9 Compare February 6, 2024 10:19
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-3855 February 6, 2024 10:19 Inactive
@davidtrussler davidtrussler marked this pull request as ready for review February 6, 2024 10:55
Copy link
Contributor

@MartinJJones MartinJJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me, I think we will also need an Interaction Designer to help review as well.

The color choice of dark-grey makes sense to me here from looking at the choice available in the Design System - https://design-system.service.gov.uk/styles/colour/

But we may also be able to us a tint to get some slightly different color variations as well:

If you need to use tints of this palette, use either 25% or 50%.

@davidtrussler
Copy link
Contributor Author

Changes look good to me, I think we will also need an Interaction Designer to help review as well.

The color choice of dark-grey makes sense to me here from looking at the choice available in the Design System - https://design-system.service.gov.uk/styles/colour/

But we may also be able to us a tint to get some slightly different color variations as well:

If you need to use tints of this palette, use either 25% or 50%.

@MartinJJones Had a call with @nnagewad about this and he's happy from a design perspective. Also, looking at tints of the dark-grey we'd be running into contrast problems at 50%.

@MartinJJones MartinJJones self-requested a review February 6, 2024 15:29
@MartinJJones
Copy link
Contributor

@MartinJJones Had a call with @nnagewad about this and he's happy from a design perspective. Also, looking at tints of the dark-grey we'd be running into contrast problems at 50%.

Thanks for checking, good to know about the contrast problem at 50% as well 👍

@MartinJJones
Copy link
Contributor

I just noticed one other small change required when reviewing the Visual changes in Percy

The "With different href" variation of the "print link" component also needs the new border color - https://components-gem-pr-3855.herokuapp.com/component-guide/print_link/preview

@davidtrussler
Copy link
Contributor Author

I just noticed one other small change required when reviewing the Visual changes in Percy

The "With different href" variation of the "print link" component also needs the new border color - https://components-gem-pr-3855.herokuapp.com/component-guide/print_link/preview

Oh yes, good spot, I'll have a look at that.

@davidtrussler davidtrussler force-pushed the 103_Button-borders-colour branch from 780c6a9 to dfa04d4 Compare February 6, 2024 16:16
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-3855 February 6, 2024 16:16 Inactive
Copy link
Contributor

@MartinJJones MartinJJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!, changes look good to me 👍

@davidtrussler davidtrussler merged commit 141c871 into main Feb 7, 2024
12 checks passed
@davidtrussler davidtrussler deleted the 103_Button-borders-colour branch February 7, 2024 09:35
@MartinJJones MartinJJones mentioned this pull request Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants